search

perfsonar / owamp

A tool for performing one-way or two-way active measurements
Apache License 2.0
70 stars 30 forks source link

Lowering some logging severities #13

Closed laeti-tia closed 7 years ago

mfeit-internet2 commented 7 years ago

The changes to OWPErrWARNING in protocol.c should probably be left at OWPErrFATAL since they all jump to err, which returns a fatal value. Doesn't seem like it would be fatal to the program, though.

Re. your other comment, the change in 6cc02ef611f4beed472238dcf2dac5db4da80da8 should probably have been severity instead of deletion. Those two were the only things that were being logged during normal operation.

laeti-tia commented 7 years ago

In protocol.c as the err part ends with a another call to OWPError() with the OWPErrFATAL severity, I thought the preceding log messages could be lowered so one can filter those out if they want. But I'm happy leaving all at OWPErrorFATAL too, and then maybe removing the very last OWPError() call that just say "Failed" as it doesn't say anything new (and that removes quite some lines in the log sample I see).

laeti-tia commented 7 years ago

@mfeit-internet2, I've revised this PR. I think it can be merged now.