twamp: ignore client's port offer if outside of server testports range

perfsonar / owamp

A tool for performing one-way or two-way active measurements

Apache License 2.0

70 stars 30 forks source link

twamp: ignore client's port offer if outside of server testports range #29

Closed vvidic closed 6 years ago

vvidic commented 6 years ago

If the twamp-server always accepts the client suggested port number it might end up binding to a port outside of testport range as defined in the config file. Ports outside of this range might be blocked by an external firewall and cause twamp test packets to be blocked.

vvidic commented 6 years ago

With this patch twping port on the server side starts to use testports 18760-19960 range:

--- twping statistics from [localhost]:9085 to [localhost]:18919 ---
SID:    7f000001de301d81c952ea772d1b3e84
first:  2018-02-15T15:53:55.076
last:   2018-02-15T15:54:05.793
100 sent, 0 lost (0.000%), 0 send duplicates, 0 reflect duplicates

vvidic commented 6 years ago

Please review this one too.

laeti-tia commented 6 years ago

Merging so that Victor can test tomorrow.