perfsonar / owamp

A tool for performing one-way or two-way active measurements
Apache License 2.0
70 stars 30 forks source link

Cleanup 12 bytes after the IPv4 address in Request-Session packet #30

Closed vvidic closed 6 years ago

vvidic commented 6 years ago

These additional bytes are there to support IPv6 addresses, but end up with some memory garbage if not zeroed explicitly.

This seems to cause problem with some TWAMP servers implementations (i.e. Juniper).

laeti-tia commented 6 years ago

Looking good to me! @mfeit-internet2 and @erik-geant can you also give a quick check?

erik-geant commented 6 years ago

seems to be safe

mfeit-internet2 commented 6 years ago

Should be fine.