Closed deastoe closed 5 years ago
The change seems to work fine for me. Maybe just use the same command line option for all commands?
Do we want to use -I for owping and -T for powstream because -I is already used there?
That's right, I used -T for powstream since -I is already used. I've no issue changing to a common flag if that's preferred.
Taking the characters of "interface" it looks like the only commonly available flag would be "-C".
Another alternative could be to overload -I for powstream, since the current usage expects an integer. So if integer parsing failed it would be interpreted as an interface instead. That seems a bit messy though.
Yes, I know that -I is usually used for interface parameter, but since that is kind of taken I had in mind some other variants like: -B (for BINDTODEVICE) -D (for device) -V (for VRF) -M (for master interface)
I don't have a strong opinion on this but once we set something we can't easily change it later so we better discuss a bit before merging the change.
Sure. I think my preference would be for -B or -D. Since owping uses -D for DSCP value that leaves -B as my preferred option.
OK, if nobody objects I will try to merge with -B than.
Great, thanks! I've updated the diffs to use -B.
Thanks for the update. Merged the patch and updated the spec file for RPM build.
Here is some example usage of the SO_BINDTODEVICE options. Here we use them for OWAMP/TWAMP operations in a VRF, by binding to the VRF master interface:
Environment:
owping
:twping
:powstream
:Example of a bind failure: