search

perfsonar / owamp

A tool for performing one-way or two-way active measurements
Apache License 2.0
70 stars 30 forks source link

owamp should take configure options into account when compiling debug-specific code #5

Closed arlake228 closed 3 years ago

arlake228 commented 9 years ago

From @arlake228 on March 14, 2015 12:52

Original issue 1067 created by arlake228 on 2015-01-30T10:23:34.000Z:

What steps will reproduce the problem?

  1. Configure owamp without --enable-debug option and run "make"
  2. Observe that logs are emitted with filenames and line numbers, and debugging CLI options are present in programs.

What is the expected output? What do you see instead? Unless "--enable-debug" is specified to configure expect that debugging CLI options are not included and log messages don't include filenames and line numbers.

What version of the product are you using? On what operating system? 3.4-10

Please provide any additional information below.

Fix available here: https://code.google.com/r/robertshearman-owamp/source/detail?r=0e429527aefbc65fe9570c2896245264bbc3336e&name=debugflag

Unrelated compile fix for an earlier commit of mine is also available here: https://code.google.com/r/robertshearman-owamp/source/detail?r=6a7cd19f4766a3ac4b8625b403c9f290188dff78&name=debugflag

Copied from original issue: perfsonar/project#1065

arlake228 commented 9 years ago

Comment #1 originally posted by arlake228 on 2015-01-30T18:12:25.000Z:

<empty>

rshearman commented 9 years ago

Any feedback on the change and the timescales for it being committed into the main owamp repository?

vvidic commented 5 years ago

Do we still have these patches somewhere?

deastoe commented 4 years ago

62 contains these and some related patches.