search

perfsonar / perl-shared

Shared libraries used by perl packages and referenced as a submodule in many git repos
Apache License 2.0
7 stars 3 forks source link

Port Debian patches upstream when possible #46

Closed laeti-tia closed 6 years ago

laeti-tia commented 6 years ago

I think we can easily port upstream some Debian packages patches so that we simplify the whole packaging. These should probably be considered for inclusion in upstream:

The other patches should be reviewed too and added if possible.

laeti-tia commented 6 years ago

@vvidic Can you also have a look at merging the ntp-config.diff patch upstream by testing the existence of the step-tickers file?

vvidic commented 6 years ago

I don't think step-tickers file is used on the Debian side so I guest there should be no harm if we add it. Will check once more and create a PR.

vvidic commented 6 years ago

The problem was nonexisting directory /etc/ntp on the Debian side. I've added this directory to perfsonar-toolkit-ntp so writing step-tickers works now and ntp-config.diff patch is removed.

laeti-tia commented 6 years ago

Thanks! Can we also then remove https://github.com/perfsonar/toolkit/blob/debian/jessie/debian/patches/debian-ntp.diff I'm not sure what's intended with the different -e -a -s flags.

vvidic commented 6 years ago

You are right, /etc/ntp exist now so the configure_ntpd should also work without patching. Dropping this patch too.

laeti-tia commented 6 years ago

I think this is all we can port upstream at the moment.