search

perfsonar / perl-shared

Shared libraries used by perl packages and referenced as a submodule in many git repos
Apache License 2.0
7 stars 3 forks source link

jsonsummary#248 #67

Closed bhavesh37 closed 5 years ago

bhavesh37 commented 5 years ago

For toolkit #248

arlake228 commented 5 years ago

One item that catches my attention is that the boolean values are not true JSON booleans. As currently defined they will get set to the strings "true" or "false" instead of JSON boolean values true or false (no quotes). To set JSON booleans properly in perl use JSON::true and JSON::false. Example:

$is_running_output = ($is_running) ? JSON::true : JSON::false;

I would recommend making that change throughout the changed file where true/false strings are being set now.