perfsonar / pscheduler

The perfSONAR Scheduler
Apache License 2.0
53 stars 32 forks source link

Refactor shared code between latency and latencybg tests #1450

Open arlake228 opened 6 days ago

arlake228 commented 6 days ago

Currently the latency and latencybg tests have a lot of copy and pasted code between them which make it challenging when you need to do updates since you have to do it in two place. Its made worse by the fact that its clearly copy and pasted but file structures and such don't even match, so its "just close enough to be annoying". For example, the result formatting is almost exactly the same even though each test has its own independent copy. Recently we fixed how bucket width is handled in latency and that did not make its way to latencybg since it was separate even though the code is similar.

We should give them some proper shared libraries between them for code like this. They are legitimately different tests, but for the common bits we should only need to update code in one place.

mfeit-internet2 commented 6 days ago

Semi-related: #994

mfeit-internet2 commented 5 days ago

The plan for this should be: