search

perftools / php-profiler

A PHP profiling library based on XHGUI Data Collector
MIT License
147 stars 26 forks source link

Add support for custom savers #63

Closed dmitryuk closed 3 years ago

dmitryuk commented 3 years ago

The PR implement possibility to create own Saver, for example, Amazon S3 or StdOut

dmitryuk commented 3 years ago

Why Travis didn't run?

glensc commented 3 years ago

Remove custom from the methods. let the method just the setSaver().

aside, your own saver you created, it's for debugging purposes? or how are you consuming them? xhgui needs to be able to import from them too?

regarding Travis: travis.org discontinued, need to migrate to travis.com or GitHub actions.

also, never crate pull request from your master branch, as it will pick up any commits you add to your master, which may not be wanted if you want to add other changes to your fork.

dmitryuk commented 3 years ago

Changed the method to setSaver. About the custom saver - in any environment I can export XHProf results to my own storage, for example, Amazon s3 and import to xhgui later using file or API method, so do the job asynchronous.

markstory commented 3 years ago

How does custom saver data get back into xhgui? Is that left up to the implementers of custom savers?

dmitryuk commented 3 years ago

About the custom saver - in any environment I can export XHProf results to my own storage, for example, Amazon s3 and import to xhgui later using file or API method, so do the job asynchronous.

This way for example.

glensc commented 2 years ago

Tests were not actually passing: https://github.com/perftools/php-profiler/pull/71