ArrayAccess Compatibility PHP 8.1+

perftools / php-profiler

A PHP profiling library based on XHGUI Data Collector

MIT License

147 stars 26 forks source link

ArrayAccess Compatibility PHP 8.1+ #77

Closed Quazz closed 2 years ago

Quazz commented 2 years ago

I found that offsetGet doesn't always return mixed, so leaving it as ReturnTypeWillChange for now

Other ones are more obvious to correct.

Fixes https://github.com/perftools/php-profiler/issues/76

glensc commented 2 years ago

LGTM

glensc commented 2 years ago

you should not create PRs from main/master branch. all commits on that branch will end up associated pull request. you might not want that if you plan to add commits there for different purpose.