perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 342 forks source link

Remove dependency with ext-xhprof in composer.json #127

Closed olivier34000 closed 9 years ago

olivier34000 commented 9 years ago

In the file composer.json there is a dependency with "ext-xhprof": "*". However the extension ext-uprofilter is valid too. I suggest to remove the dependency

preinheimer commented 9 years ago

We've talked about this a bit. The ideal situation would be an "OR" option inside composer.json, (ext-xhprof OR ext-uprofiler) but that's not an option yet. We would also like to call out to people during the installation process that something is required.

What about composer.json and composer.json.uprofiler or some other chicanery?

akrabat commented 9 years ago

I've just been bitten by this.

Setting it as a "suggestion" would enable you to call out the requirement for one of them.

markstory commented 9 years ago

I think #135 fixes this.