search

perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 342 forks source link

Decide on coding style and enforce mostly with PHPCS #299

Open Krinkle opened 4 years ago

Krinkle commented 4 years ago

Less burden on reviewers, less guess work on the contributing person (ergo me). Also automation in supporting IDEs with automatic fixing/adapting as needed.

It looks like the current code looks mostly like PSR-2. Is that intentional?

(Extracted out of https://github.com/perftools/xhgui/issues/16)

markstory commented 4 years ago

It looks like the current code looks mostly like PSR-2. Is that intentional?

Yes and no. I think PSR2 is a good base target to get to. I never got around to fully updating the existing code though.

glensc commented 4 years ago

@markstory perhaps remove Sticker CI integration? it seems broken and no support.

It's marked CI job as failed, example: https://github.com/perftools/xhgui/pull/363

but can't retrieve any details why.

the link from PR leads to https://stickler-ci.com/repositories/156-perftools-xhgui but that says "bummer, The requested address /repositories/156-perftools-xhgui was not found."

The "login" on the page leads to https://stickler-ci.com/github/authorize, and redirects back to the same page, and even still shows "login" even I've logged in.

I've contacted their support, and they have not even responded over several months.

can you remove the integration? as I think I don't even have permission to remove the integration.

markstory commented 4 years ago

@glensc Oddly enough I run stickler, and never got any support emails. I can look into what is not working with the login flow. There are build logs and results in the Github checks views though.

glensc commented 4 years ago

@markstory ok, I can see output via GitHub actions, so I guess can leave as is then.

The other link gave an error and I contacted their support, but the ☎️ is dead

image