search

perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 342 forks source link

Saver: Drop "get" key requirement from profiler data on submit #404

Closed glensc closed 3 years ago

glensc commented 3 years ago

Drop "get" key from profiler data when it's submitted. The value is now extracted from "url", so sending "get" data is redundant.

Profiler no longer needs to send "get" over the wire. The individual savers may choose not to store this down separately.

glensc commented 3 years ago

The "url" for CLI may fail here:

need to ensure empty [] get is assigned in this case.

as the CI passed, that means that scenario is not in phpunit.

glensc commented 3 years ago

Looks like the test fixture is even out of sync, "url" has get parameters but "get" is empty: