perftools / xhgui

Web interface for XHProf profiling data can store data in MongoDB or PDO database
1.65k stars 342 forks source link

Replace sql type text by longtext for profile field in PdoRepository #437

Closed mkeromen closed 2 years ago

mkeromen commented 2 years ago
glensc commented 2 years ago
1) XHGui\Test\Controller\RunTest::testIndexEmpty
PDOException: SQLSTATE[42704]: Undefined object: 7 ERROR:  type "longtext" does not exist
LINE 4:               "profile"          LONGTEXT       NOT NULL,

looks like this is database dependent, so far we've avoided abstracting database type:

glensc commented 2 years ago

I've added the driver name to the repository class:

so this could be evaluated to make driver-specific changes

glensc commented 2 years ago

Rebased and changed target branch, so pay attention to update your local branch first if you add more commits to this branch

glensc commented 2 years ago

@mkeromen close, since you're no longer interested in this?

Charl13 commented 2 years ago

@glensc This is actually rather important since json_decode() silently returns null on truncated data. That means no error and empty results in the callgraph. Harder to debug.

glensc commented 2 years ago

Closing, as seems the original author is not interested in finishing this.

Charl13 commented 2 years ago

@glensc What about my comment? Do you want me to open a new pull request?

glensc commented 2 years ago

@Charl13 up to you

Charl13 commented 2 years ago

https://github.com/perftools/xhgui/pull/474 🙏🏽