Walking back dependency version fails to invalidate constraints

periareon / req-compile

Python requirements compilation

MIT License

14 stars 4 forks source link

Walking back dependency version fails to invalidate constraints #11

Closed jnguyen75 closed 3 years ago

jnguyen75 commented 3 years ago

In our repository, we have a dependency walks back a version of Flask, but in doing so, fails to walk back some of its contributing constraints.

sputt commented 3 years ago

Confirmed with a simple testcase. The issue appears when a constraint is walked back at least two versions. What happens is the solver retains a reference to one of the stale nodes and attempts to solve it next round - but actually it should verify it's still in the solution before solving