Fixed simultaneous assertion of exception type and message.

peridot-php / leo

Next level assertion and matcher library for PHP

http://peridot-php.github.io/leo/

MIT License

35 stars 7 forks source link

Fixed simultaneous assertion of exception type and message. #24

Closed ezzatron closed 8 years ago

ezzatron commented 8 years ago

Re-do of #21, predicated on #22 and #23 .

This PR addresses #20. In short, Leo's ExceptionMatcher was bypassing the type check when an expected exception message was specified.

FYI, I have a few PRs to come, and a couple are predicated on this one.

coveralls commented 8 years ago

Coverage decreased (-0.4%) to 99.593% when pulling 902665d77948349a336364b8d088a8565e4e860b on ezzatron:fix-throw into 5ff1a9481faa37a55f5c6569379858dca01312f6 on peridot-php:master.

codecov-io commented 8 years ago

Current coverage is 99.41% (diff: 100%)

Merging #24 into master will decrease coverage by 0.35%

@@             master        #24   diff @@
==========================================
  Files            40         40          
  Lines           849        848     -1   
  Methods         202        201     -1   
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            847        843     -4   
- Misses            2          5     +3   
  Partials          0          0

Powered by Codecov. Last update 55e0d1a...6f040fe