search

periodo / periodo-client

Client to browse and edit PeriodO data
https://client.perio.do
Other
15 stars 2 forks source link

PeriodO Client not accepting all the changes made to an existing authority #323

Open ylan1 opened 3 years ago

ylan1 commented 3 years ago

A couple of weeks ago, I tried to make two changes (stop date and adding alternative labels) to the authority record (http://n2t.net/ark:/99152/p0wf3wdnm6q).
After submitting the changes, I noticed that only the alternative label field was updated, and the stop date reverted to the original, incorrect value. I tested twice, and the result was the same.

Before submitting before

After submitting after

Last week, I separately submitted the stop date change that did not work the first time, and it seems to have worked. So I assume that the Client currently is only accepting one field change.

atomrab commented 3 years ago

I merged this submission and can confirm that the submitted version included a successful end-date change.

atomrab commented 2 years ago

@rybesh Is this related to the problem the person who submitted the BSA periodization is having with attempts to change language and date labels? She writes:

I had to go back again several times to fix the labels because they were returning to the previous ones (when I was changing English to Modern Greek and BCE to BC) . Maybe it's just a glitch. In the end I had to work on the json file, that I downloaded and reimported as a backup file.

Will make a new issue if you think this is a different problem.

atomrab commented 1 year ago

@rybesh I've replicated this problem with an edit to the ArkeOpen collection, in which I edited both the start date and the source note and submitted a patch that recognized changes to both of those fields. The merged version, however, only included the change to the source notes, and dropped the change to the date. A second patch with the changed entry from the same local collection shows only the date change and merges successfully.

Without knowing how the programming works, I would hazard the guess that the change-submission or merge script only recognizes changes to the single most recently edited field, so by default only updates one value, no matter which field was edited.