Cancel button in Add Period editing window does not work in Firefox

atomrab commented 9 years ago

I started to add a period to a local collection I'd made for the CHGIS periodization, but then decided I wanted to cancel it out to fix a mistake in the previous period I'd added. Clicking the cancel button did not cause any change to the state of the page. When I hit the back button on the browser, thinking I could back out, the client reverted to the database selection page -- and when I tried to access the local idb, nothing appeared but the following error message (the database seems to have disappeared, even on reload):

ptgolden commented 9 years ago

OK, it looks like something got stuck in a bad state in that collection. I'll make sure that it gets fixed when I release a new version next week.

Nothing has disappeared, the code just expects something in your dataset that's not there. Browse to https://test.perio.do/#p/ and everything should be fine- though you will not be able to use that backend for the time being.

atomrab commented 9 years ago

I can still see all the backends at that address, but can't get to the one I just made (only has one value in it anyway). I will just wait until I hear from you again, I guess, before putting more data in.

Ryan, this is the kind of trial-and-error that led me to put stuff in spreadsheets -- Sarah couldn't lose time, and I was worried about losing data or making new redundant databases when one broke like this. I know it's not best practice, and we certainly need to test the client, but not being able to see data you've generated in an interface is alarming for the less technically savvy.

rybesh commented 9 years ago

not being able to see data you've generated in an interface is alarming for the less technically savvy

Yep, which is why we're making sure that the client has been well-tested internally before we ask the general public to use it. Remember, you're on the development team, you're not a customer... :grin:

atomrab commented 9 years ago

Yeah, I know. I was just trying to explain why I keep falling back on spreadsheets!

ptgolden commented 9 years ago

I updated the client so that it won't choke when given a period without all the data it expects. You'll see one period in the China Historical GIS list that has no label, start, or stop dates. It inadvertently got saved for whatever reason. You'll probably want to delete it.

atomrab commented 9 years ago

I'll be happy to delete it. It's probably the one I was trying to start when the idb broke. Is it in the data on the server now?

On Mon, Jul 13, 2015 at 3:40 PM, Patrick Golden notifications@github.com wrote:

I updated the client so that it won't choke when given a period without all the data it expects. You'll see one period in the China Historical GIS list that has no label, start, or stop dates. It inadvertently got saved for whatever reason. You'll probably want to delete it.

— Reply to this email directly or view it on GitHub https://github.com/periodo/periodo-client/issues/52#issuecomment-121049851 .

ptgolden commented 9 years ago

no

On Jul 13, 2015, at 6:10 PM, atomrab notifications@github.com wrote:

I'll be happy to delete it. It's probably the one I was trying to start when the idb broke. Is it in the data on the server now?

On Mon, Jul 13, 2015 at 3:40 PM, Patrick Golden notifications@github.com wrote:

I updated the client so that it won't choke when given a period without all the data it expects. You'll see one period in the China Historical GIS list that has no label, start, or stop dates. It inadvertently got saved for whatever reason. You'll probably want to delete it.

— Reply to this email directly or view it on GitHub https://github.com/periodo/periodo-client/issues/52#issuecomment-121049851 .

— Reply to this email directly or view it on GitHub.

periodo / periodo-client

Cancel button in Add Period editing window does not work in Firefox #52