Support SGP30 over I2C - Githubissues

periph / devices

Go·Hardware·Lean - Device drivers

https://periph.io

Apache License 2.0

85 stars 42 forks source link

Support SGP30 over I2C #32

Closed 0x46616c6b closed 2 years ago

0x46616c6b commented 2 years ago

What kind of new feature are you looking for?

Hardware: SGP30

I implemented in this repository the SGP30 already and want to ask if I can contribute this piece of code. It is fully functional but I did not implemented the CRC checks which are mentioned in the datasheet.

Do you plan to:

Contribute an initial driver: Yes
Write unit tests: No
Update https://github.com/periph/cmd to use the new functionality: Yes

maruel commented 2 years ago

It looks great! The only nit would be to not export the commands. Thanks!