periph / devices

Go·Hardware·Lean - Device drivers
https://periph.io
Apache License 2.0
91 stars 45 forks source link

waveshare213v2: Add tests for clearing, use better color type #39

Closed hansmi closed 2 years ago

hansmi commented 2 years ago

This is an API-breaking change, albeit a simple one: Previously the Dev.Clear function received a byte named "color". It was sent directly to the display, thus acting more like a pattern to fill the display with. In practice only 0 and 255 are likely to be used (equivalent to image1bit.Off and image1bit.On respectively). To match the Dev.Draw interface a generic color.Color is now used.

codecov-commenter commented 2 years ago

Codecov Report

Merging #39 (e759762) into main (ecc1eed) will increase coverage by 0.2%. The diff coverage is 85.2%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #39     +/-   ##
=======================================
+ Coverage   62.3%   62.5%   +0.2%     
=======================================
  Files         55      55             
  Lines       6708    6720     +12     
=======================================
+ Hits        4179    4202     +23     
+ Misses      2388    2377     -11     
  Partials     141     141             
Impacted Files Coverage Δ
waveshare2in13v2/waveshare213v2.go 0.0% <0.0%> (ø)
waveshare2in13v2/drawing.go 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ecc1eed...e759762. Read the comment docs.