search

periph / host

Go·Hardware·Lean - Host drivers
https://periph.io
Apache License 2.0
53 stars 27 forks source link

Allwinner: Implement nanopi neo air #30

Closed biotinker closed 1 year ago

biotinker commented 1 year ago

This builds off of #23 to expand support to also include the nanoPi Neo Air board. It also updates the Allwinner H3 pin mapping to properly support the PL pins, something that was missing in the #23 PR.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov-commenter commented 1 year ago

Codecov Report

Merging #30 (067bd1f) into main (339d73c) will not change coverage. The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main     #30   +/-   ##
=====================================
  Coverage   34.3%   34.3%           
=====================================
  Files         51      51           
  Lines       7992    7992           
=====================================
  Hits        2744    2744           
  Misses      5117    5117           
  Partials     131     131
Impacted Files Coverage Δ
cpu/cpu.go 94.9% <100.0%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

maruel commented 1 year ago

Ran go mod tidy and pushed. Please pull and rebase and fix CI checks.

biotinker commented 1 year ago

CI checks should now all be passing

maruel commented 1 year ago

The go mod tidy failure is abnormal since I had fixed it. Will look later what the heck is happening. Sorry about that.

biotinker commented 1 year ago

Extra weird is that the CI checks pass in my personal repo, but should presumably be using the exact same workflow as here...

https://github.com/biotinker/host/actions/runs/4491701924

biotinker commented 1 year ago

Anything I can do to help get this through? Happy to look into the failure more given a starting point