search

periph / host

Go·Hardware·Lean - Host drivers
https://periph.io
Apache License 2.0
57 stars 32 forks source link

fs,sysfs: use EPOLL_EXEC to clean up epoll file descriptors on execve(2) #32

Closed eliasnaur closed 1 year ago

eliasnaur commented 1 year ago

EPOLL_EXEC is O_CLOEXEC for epoll_create1, which is a good default for any file descriptor not explicitly designed to survive an exec.

maruel commented 1 year ago

The error is not your fault, let me take a look in O(hours) to O(days).

maruel commented 1 year ago

https://github.com/periph/host/pull/33 should fix it

maruel commented 1 year ago

Can you try rebasing on top of origin/main now?

eliasnaur commented 1 year ago

Done.

maruel commented 1 year ago

Released as https://github.com/periph/host/releases/tag/v3.8.1

eliasnaur commented 1 year ago

Released as https://github.com/periph/host/releases/tag/v3.8.1

Really? As far as I can tell, v3.8.1 doesn't contain this change. It does contain the go 1.20 bump, however.

maruel commented 1 year ago

Operator error, see https://github.com/periph/host/releases/tag/v3.8.2

eliasnaur commented 1 year ago

Thanks a lot!