search

periscop / cloog

The CLooG Code Generator in the Polyhedral Model
GNU Lesser General Public License v2.1
40 stars 23 forks source link

compiler build warnings #43

Closed bondhugula closed 5 years ago

bondhugula commented 5 years ago

With GCC 8.3.1 and with -Wextra, I see the following warnings. (Besides the sign comparison warnings, there are several 'unused parameter' ones.)

CC source/libcloog_isl_la-version.lo source/union_domain.c: In function ‘cloog_scattering_list_read’: source/union_domain.c:174:47: warning: unused parameter ‘nb_parameters’ [-Wunused-parameter] CloogDomain **domain, int nb_statements, int nb_parameters)


source/union_domain.c: In function ‘cloog_union_domain_from_osl_scop’:
source/union_domain.c:332:19: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
     for (i = 0; i < osl_strings_size(scop->parameters->data); i++) {
                   ^
source/union_domain.c:357:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
     for (i = 0; (i < osl_strings_size(scatnames->names)) &&
                    ^
  CC       source/isl/libcloog_isl_la-domain.lo
  CC       source/isl/libcloog_isl_la-constraints.lo
  CC       source/isl/libcloog_isl_la-backend.lo
  CC       test/generate_test_advanced.o
source/isl/domain.c: In function ‘cloog_scattering_fully_specified’:
source/isl/domain.c:51:24: warning: unused parameter ‘domain’ [-Wunused-parameter]
           CloogDomain *domain)
           ~~~~~~~~~~~~~^~~~~~
source/isl/domain.c: In function ‘cloog_domain_sort’:
source/isl/domain.c:247:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nb_doms; i++) {
                ^
source/isl/domain.c:254:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nb_doms; ++i) {
                ^
source/isl/domain.c:257:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   for (j = 0; j < nb_doms; ++j)
                 ^
source/isl/domain.c:261:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 1; i < nb_doms; ++i) {
                ^
source/isl/domain.c:290:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0, j = 0; i < nb_doms; j = (j + 1) % nb_doms) {
                       ^
source/isl/domain.c:291:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   for (k = 0; k < nb_doms; ++k)
                 ^
source/isl/domain.c:294:9: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   if (k < nb_doms)
         ^
source/isl/domain.c:296:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   for (k = 0; k < nb_doms; ++k)
                 ^
source/isl/domain.c:303:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nb_doms; ++i)
                ^
source/isl/domain.c: In function ‘cloog_domain_read_scattering’:
source/isl/domain.c:505:39: warning: comparison of integer expressions of different signedness: ‘isl_size’ {aka ‘int’} and ‘unsigned int’ [-Wsign-compare]
  if (isl_map_dim(scat, isl_dim_param) != nparam) {
                                       ^~
source/isl/domain.c:510:36: warning: comparison of integer expressions of different signedness: ‘isl_size’ {aka ‘int’} and ‘unsigned int’ [-Wsign-compare]
  if (isl_map_dim(scat, isl_dim_in) != dim) {
                                    ^~
source/isl/domain.c: In function ‘isl_basic_set_read_from_matrix’:
source/isl/domain.c:578:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nrows; ++i) {
                ^
source/isl/domain.c: In function ‘isl_basic_map_read_from_matrix’:
source/isl/domain.c:611:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nrows; ++i) {
                ^
source/isl/domain.c: In function ‘constraint_can_stride’:
source/isl/domain.c:873:17: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   for (i = 0; i < n_div; ++i) {
                 ^
source/isl/domain.c:879:9: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   if (i < n_div)
         ^
source/isl/domain.c: In function ‘cloog_scattering_lazy_block’:
source/isl/domain.c:1283:13: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘isl_size’ {aka ‘int’} [-Wsign-compare]
  if (n_scat != isl_map_dim(map2, isl_dim_out))
             ^~
source/isl/domain.c:1293:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < n_scat; ++i) {
                ^
source/isl/domain.c:1303:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   if (i + 1 < n_scat){
             ^
source/isl/domain.c:1318:12: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  block = i >= n_scat;
            ^~
source/isl/domain.c:1270:41: warning: unused parameter ‘scattdims’ [-Wunused-parameter]
    CloogScatteringList *scattering, int scattdims)
                                     ~~~~^~~~~~~~~
source/isl/domain.c: In function ‘cloog_scattering_dimension’:
source/isl/domain.c:1370:69: warning: unused parameter ‘domain’ [-Wunused-parameter]
 int cloog_scattering_dimension(CloogScattering *scatt, CloogDomain *domain)
                                                        ~~~~~~~~~~~~~^~~~~~
source/isl/domain.c: In function ‘count_same_name’:
source/isl/domain.c:1645:25: warning: operand of ?: changes signedness from ‘isl_size’ {aka ‘int’} to ‘unsigned int’ due to unsignedness of other operand [-Wsign-compare]
   s = t == type ? pos : isl_space_dim(dim, t);
                         ^~~~~~~~~~~~~~~~~~~~~
source/isl/constraints.c: In function ‘cloog_constraint_set_contains_level’:
source/isl/constraints.c:107:19: warning: unused parameter ‘nb_parameters’ [-Wunused-parameter]
    int level, int nb_parameters)
               ~~~~^~~~~~~~~~~~~
source/isl/constraints.c: In function ‘basic_set_cloog_dim_to_isl_dim’:
source/isl/constraints.c:128:11: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   if (pos < dim) {
           ^
source/isl/constraints.c: In function ‘cloog_constraint_set_defining_inequalities’:
source/isl/constraints.c:211:42: warning: unused parameter ‘nb_par’ [-Wunused-parameter]
  int level, CloogConstraint **lower, int nb_par)
                                      ~~~~^~~~~~
source/isl/constraints.c: In function ‘cloog_constraint_set_n_iterators’:
source/isl/constraints.c:247:75: warning: unused parameter ‘n_par’ [-Wunused-parameter]
 int cloog_constraint_set_n_iterators(CloogConstraintSet *constraints, int n_par)
                                                                       ~~~~^~~~~
source/isl/constraints.c: In function ‘cloog_equal_add’:
source/isl/constraints.c:417:66: warning: unused parameter ‘matrix’ [-Wunused-parameter]
 void cloog_equal_add(CloogEqualities *equal, CloogConstraintSet *matrix,
                                              ~~~~~~~~~~~~~~~~~~~~^~~~~~
source/isl/constraints.c:418:42: warning: unused parameter ‘nb_par’ [-Wunused-parameter]
    int level, CloogConstraint *line, int nb_par)
                                      ~~~~^~~~~~
source/isl/constraints.c: In function ‘cloog_constraint_set_normalize’:
source/isl/constraints.c:456:57: warning: unused parameter ‘matrix’ [-Wunused-parameter]
 void cloog_constraint_set_normalize(CloogConstraintSet *matrix, int level)
                                     ~~~~~~~~~~~~~~~~~~~~^~~~~~
source/isl/constraints.c:456:69: warning: unused parameter ‘level’ [-Wunused-parameter]
 void cloog_constraint_set_normalize(CloogConstraintSet *matrix, int level)
                                                                 ~~~~^~~~~
source/isl/constraints.c: In function ‘cloog_constraint_set_simplify’:
source/isl/constraints.c:494:19: warning: unused parameter ‘equal’ [-Wunused-parameter]
  CloogEqualities *equal, int level, int nb_par)
  ~~~~~~~~~~~~~~~~~^~~~~
source/isl/constraints.c:494:30: warning: unused parameter ‘level’ [-Wunused-parameter]
  CloogEqualities *equal, int level, int nb_par)
                          ~~~~^~~~~
source/isl/constraints.c:494:41: warning: unused parameter ‘nb_par’ [-Wunused-parameter]
  CloogEqualities *equal, int level, int nb_par)
                                     ~~~~^~~~~~
source/isl/constraints.c: In function ‘constraint_cloog_dim_to_isl_dim’:
source/isl/constraints.c:510:11: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
   if (pos < dim) {
           ^
source/isl/constraints.c: In function ‘div_expr’:
source/isl/constraints.c:536:29: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0, nb_elts = 0; i < dim; ++i) {
                             ^
source/isl/constraints.c:557:29: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0, nb_elts = 0; i < dim; ++i) {
                             ^
source/isl/constraints.c: In function ‘cloog_constraint_copy_coefficients’:
source/isl/constraints.c:806:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < dim; ++i)
                ^
source/isl/constraints.c: In function ‘cloog_constraint_set_reduce’:
source/isl/constraints.c:941:41: warning: unused parameter ‘nb_par’ [-Wunused-parameter]
  int level, CloogEqualities *equal, int nb_par, cloog_int_t *bound)
                                     ~~~~^~~~~~
source/isl/constraints.c: In function ‘extract_stride_offset’:
source/isl/constraints.c:1082:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nparam; ++i) {
                ^
source/isl/constraints.c:1087:16: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
  for (i = 0; i < nvar; ++i) {
                ^
harenome commented 5 years ago

Do you still get warnings on your setup with the current master head?

bondhugula commented 5 years ago

The warnings are now gone, thanks!