search

periscop / cloog

The CLooG Code Generator in the Polyhedral Model
GNU Lesser General Public License v2.1
40 stars 23 forks source link

Build warning - source/pprint.c #44

Open bondhugula opened 5 years ago

bondhugula commented 5 years ago

I notice one build warning with gcc (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)

CC source/libcloog_isl_la-statement.lo In function ‘pprint_replacestr’, inlined from ‘pprint_replacestr’ at source/pprint.c:436:7: source/pprint.c:457:5: warning: ‘strncat’ specified bound depends on the length of the source argument [-Wstringop-overflow=] 457 | strncat(result, replace, strlen(replace)); | ^~~~~~~~~

The line numbers may not match with the master branch (as I have a forked version), but here's the code snippet for context:

while ((pos1 = strstr(pos, sub))) {
  int len = (pos1 - pos);
  strncat(result, pos, len);
  strncat(result, replace, strlen(replace));
  pos = (pos1 + strlen(sub));
}
harenome commented 5 years ago

Hi, are you sure this snippet is not specific to your local version? I can not find any use of strstr() or strncat() in master.

Syllo commented 5 years ago

Hi, The function pprint_replacestr is not present, anywhere in CLooG source files, at least in the master branch :wink: