Update osl_int - Githubissues

periscop / openscop

A Specification and a Library for Data Exchange in Polyhedral Compilation Tools

BSD 3-Clause "New" or "Revised" License

26 stars 14 forks source link

Update osl_int #12

Closed Lnc closed 10 years ago

Lnc commented 10 years ago

Remove mpz_t* casts
Add osl_int_size_in_base_2 function
Add osl_int_floor_div*, osl_int_mod, osl_int_gcd and osl_int_size_in_base_10 functions
Use const in osl_int* functions
Add overflow detection
Add osl_int test (in CMake only)

Lnc commented 10 years ago

It is ok for me now :)

periscop commented 10 years ago

(Global remark) OK for me except my remarks on "Add osl_int_test". Is it workable or would you prefer me to pull it and you want to correct it in a forthcoming commit (not very clean but I don't care much) ?

Lnc commented 10 years ago

Fixed in new pull request: https://github.com/periscop/openscop/pull/16