peritus / bumpversion

Version-bump your software with a single command
https://pypi.python.org/pypi/bumpversion
MIT License
1.5k stars 148 forks source link

tag name contains double quotes #191

Closed AlaaAttya closed 5 years ago

AlaaAttya commented 5 years ago
[bumpversion]
current_version = 1.0.2
commit = True
tag = True
tag_name = "v{new_version}"

when using the following config file it ends up adding double quotes around tag name in the releases like this "v1.0.0" instead of v1.0.0

peritus commented 5 years ago

Remove the double quotes in the config file maybe ?

AlaaAttya commented 5 years ago

if i use this tag_name = v{new_version} it shows this error

Git working directory is not clean:
M .bumpversion.cfg

Use --allow-dirty to override this if you know what you're doing.
Traceback (most recent call last):
  File "/usr/local/bin/bumpversion", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/bumpversion/__init__.py", line 897, in main
    vcs.assert_nondirty()
  File "/usr/local/lib/python2.7/site-packages/bumpversion/__init__.py", line 109, in assert_nondirty
    b"\n".join(lines)))
bumpversion.WorkingDirectoryIsDirtyException
AlaaAttya commented 5 years ago

@peritus are you able to reproduce it?

SitiSchu commented 5 years ago

@AlaaAttya The reason you're getting that error is because you edited your .bumpversion.cfg and didnt commit the changes. Commit your changes and try again.

AlaaAttya commented 5 years ago

@SitiSchu your trick got my issue fixed, thanks a million :)