search

peritus / bumpversion

Version-bump your software with a single command
https://pypi.python.org/pypi/bumpversion
MIT License
1.5k stars 147 forks source link

Force ascii encoding when adding env variables #68

Closed russgray closed 9 years ago

russgray commented 9 years ago

Windows doesn't like unicode strings in the environment, causing commits to fail with the error TypeError: environment can only contain strings. Fixes #67

russgray commented 9 years ago

Sorry, I see there's already a pull request fixing the same issue, I'll close this

peritus commented 9 years ago

That's sad :(

The other pull request is missing a proper test demonstrating the issue and that's why I haven't merged it. Perhaps your code had that ?

russgray commented 9 years ago

As the other dev said, it's a bit tricky to demonstrate in a test because currently the test suite doesn't run at all in Windows due to the same issue (the HGENCODING environment var is added on line 23 of tests.py and has the same problem). Maybe you'd accept a pull request that allows the tests to run, at which point the commit tests will fail on Windows, and then another pull request that makes those tests pass? I don't think there's an easy new test to write here; the existing commit tests would cover it.

peritus commented 9 years ago

Sure.

Looks like I need to find a way to have some windows with my continuous integration.