Missing code tests - Githubissues

peritus / bumpversion

Version-bump your software with a single command

https://pypi.python.org/pypi/bumpversion

MIT License

1.5k stars 147 forks source link

Missing code tests #91

Closed lgiordani closed 8 years ago

lgiordani commented 9 years ago

The whole test suite lacks tests of the code structures (such as VersionPart or ConfiguredVersionPartConfiguration). May I add some tests on those classes? it is always useful to have some basic behaviour tests.

Moreover, in another issue I'm going to propose some changes to these structures so this could allow to spot subtle errors.

peritus commented 8 years ago

Now that #98 is merged, this can be closed ? I haven't checked coverage, but if you feel confident with it, @lgiordani please feel free to close this.

lgiordani commented 8 years ago

Absolutely. There is probably still some areas to test, but given the refactoring we are doing I'd say this issue served its purpose. Thanks