search

peritus / bumpversion

Version-bump your software with a single command
https://pypi.python.org/pypi/bumpversion
MIT License
1.5k stars 147 forks source link

Classes cleanup and tests #98

Closed lgiordani closed 8 years ago

lgiordani commented 9 years ago

This is an implementation of #91 and #92 and partially #93. (I opened this one to cleanup the history mess with #95)

peritus commented 9 years ago

I like this pull request a lot in general.

I'm kind of hesitant on the naming of *Engine (with the meaning of "something that does something"). I would merge this regardless, but would probably search for a new name before making this part of a documented/public facing/stable/commited API. What would be a good name for these things ?

lgiordani commented 9 years ago

Yes I was not really happy about Engine too, but could not find another name at the time and then forgot it. Since I have to change the PR to move DateEngine I can also make a change here. Those Engine are classes that rule the way a part of a version changes. So this is a "rule for a part of a version". "Rule"? "Function?" That upcoming next step I was talking about in a comment mkaes use of a configuration flag that I called "function", so perhaps "*Function" could be a more viable solution. What do you think?

lgiordani commented 9 years ago

I replaced *Engine with *Function and removed DateEngine.