search

perkeep / gphotos-cdp

This program uses the Chrome DevTools Protocol to drive a Chrome session that downloads your photos stored in Google Photos.
Apache License 2.0
651 stars 36 forks source link

navLeft: add events based mechanism to wait for page readiness #11

Closed mpl closed 4 years ago

mpl commented 4 years ago

Fixes #6

daneroo commented 4 years ago

I like it, and it works for me. I tried repeated cycles from 2 different accounts.

If we have enough examples of how the timeouts occur, we might be able to figure out some kind of retry behavior from the calling navN, but I think it's a useful enhancement.

It also validates the event-based approach to the interactions with chromedp.

I also like the use of RWMutex which I was not familiar with.