search

perkeep / gphotos-cdp

This program uses the Chrome DevTools Protocol to drive a Chrome session that downloads your photos stored in Google Photos.
Apache License 2.0
651 stars 36 forks source link

Out of curiousity, why do you nav to end with PgDowns rather than Ctrl+End ? #28

Closed aviramsegal closed 3 years ago

aviramsegal commented 3 years ago

https://github.com/perkeep/gphotos-cdp/blob/e9d1979707191993f1c879ae93f8dd810697fd6e/main.go#L315

It feels like Ctrl+End is much more efficient as it just jumps to the end at once rather goes through your entire library. Is there any specific reason for using PgDowns and comparing screenthots ?

mpl commented 3 years ago

No reason other than ignorance. If Ctrl+end works better and works on all platforms, then we should definitely use it.

On Sat, Oct 31, 2020, 09:10 Aviram Segal notifications@github.com wrote:

https://github.com/perkeep/gphotos-cdp/blob/e9d1979707191993f1c879ae93f8dd810697fd6e/main.go#L315

It feels like Ctrl+End is much more efficient as it just jumps to the end at once rather goes through your entire library. Is there any specific reason for using PgDowns and comparing screenthots ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/perkeep/gphotos-cdp/issues/28, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEY3F4BBQC3E526IOSEJATSNPA7JANCNFSM4TFYCUWA .

aviramsegal commented 3 years ago

Thanks for the quick reply. On Mac and Windows Ctrl+End works. I'll try to find some time this week to test on Linux and send a PR if it works s well.

aviramsegal commented 3 years ago

Took another look at it Ctrl+End does immediately get to the end but every once in a while it jumps back a bit. it isn't much faster than current behavior on a very big library.