googlebot
commented
3 years ago Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
HuwSy
Issue Slow internet speeds and slow page loads prevent navigating to end correctly without resulting in many many navRight steps. Additionally impacts navLeft when this doesn’t load in a timely manner (or possibly portrait photos TBC)
Background The page down/end detection done off screen shots when the unpopulated gray tiles match again and again doesn’t recognise its not reached the end.
Implementation By waiting slightly longer between pagination it at least loads the gray boxes to correct proportions and identifies the page has not reached end. Also adding a nudge the window.resize() before attempting click left better tolerate slow page loads with large images or videos on slow connections.
Fix for issue #33 and possibly #19