search: let describe specify which attributes to return

perkeep / perkeep

Perkeep (née Camlistore) is your personal storage system for life: a way of storing, syncing, sharing, modelling and backing up content.

https://perkeep.org/

Apache License 2.0

6.49k stars 447 forks source link

search: let describe specify which attributes to return #435

Open bradfitz opened 10 years ago

bradfitz commented 10 years ago

Sometimes a recently-modified permanode has tons of attributes.

But the web UI rarely needs them all.

The Describe mechanism could also let the caller specify which attribute(s) to return.

(this is related to issue #319)

aboodman commented 10 years ago

Comment 1:

I'm regularly seeing search responses now that are ~1MB because of this. Mostly because
of large numbers of camliPath:* attributes.

bradfitz commented 10 years ago

Comment 2:

What's the search query and response (or subset of it)?

bradfitz commented 10 years ago

Comment 3:

I think this is fixed now with *search.Describe.Rules (DescribeRule).  If there are
cases remaining, please file bugs with details.

Status changed to Fixed.

bradfitz commented 10 years ago

Comment 4:

Nevermind, this isn't fixed.

Owner changed to @bradfitz.

Status changed to Accepted.