Error when using non-ASCII character in permanode title

perkeep / perkeep

Perkeep (née Camlistore) is your personal storage system for life: a way of storing, syncing, sharing, modelling and backing up content.

https://perkeep.org/

Apache License 2.0

6.49k stars 447 forks source link

Error when using non-ASCII character in permanode title #450

Closed camlistorebot closed 9 years ago

camlistorebot commented 10 years ago

by havard.haugen:

Attempting to set the title or tag of a permanode to the letter "Ø" leads to
a pop-up in Chrome saying:

"upload permanode fail, expected blobRef not in response".

The correponding log entry says:

2014/05/23 21:05:47 Client error: Error receiving blob
sha1-e379ad6c6be49c1e09c552e0f7078360b28f7e77: corrupt blob; digest doesn't match

bradfitz commented 10 years ago

Comment 1:

Ouch. Yes, I can reproduce. Thanks for the report!
Looks like something is missing a charset=utf-8 in the signing and/or upload handlers.
Or the Javascript is forgetting to send it.

Owner changed to @mpl.

Status changed to Accepted.

mpl commented 10 years ago

Comment 2:

ugh. that took way longer than it should have since I wasn't debugging in the right
place at all. tricky.
https://camlistore-review.googlesource.com/3016

Status changed to Started.

mpl commented 10 years ago

Comment 3:

the blobserver was actually getting the correct contents, and the blobRef hash it was
calculating was hence correct too, but it was comparing it to the blobRef hash sent by
the js (which was used as the formName) which was actually faulty.

mpl commented 10 years ago

Comment 4:

58aeb1bd01a182cc504bc4b6adc8a0970c842fd2

Status changed to Fixed.