search

perkinss / Beachcomber

The ONC beachcomber app
1 stars 1 forks source link

Images in table views are not same size #20

Closed jrproctor closed 12 years ago

jrproctor commented 12 years ago

Images in the left side of both table views (PhotoTableViewController and PhotoSelectionViewController) are all different sizes. It would be tidier if we could make these the same size. Could be as simple as adjusting the thumb nails so they always have 1:1 proportion.

perkinss commented 12 years ago

I think it's because the original images were not taken with the iPhone camera. When the images are all taken with the camera it's fine. I noticed this too.. There's a size difference between the iPhone camera photos and the default test photos

Sent from my iPhone

On 2012-07-31, at 12:02 PM, jrproctorreply@reply.github.com wrote:

Images in the left side of both table views (PhotoTableViewController and PhotoSelectionViewController) are all different sizes. It would be tidier if we could make these the same size. Could be as simple as adjusting the thumb nails so they always have 1:1 proportion.

Reply to this email directly or view it on GitHub: https://github.com/perkinss/Beachcomber/issues/20

jrproctor commented 12 years ago

what if some of the images are portrait and some are landscape?

perkinss commented 12 years ago

because of the default orientation, the iPhone photos, for now, will be displayed with the same size But I wonder if, when we fix the issue with the photo orientation, the issue will become more apparent. At which point we should fix that problem. Right now I think it may be due to the size of the default images.

perkinss commented 12 years ago

OK, so now that we are saving in jpeg format, the orientation seems to have fixed itself, and now we see the images in different orientations in the table.

jrproctor commented 12 years ago

I changed the thumbnail procedure to guarantee a square thumbnail is produced. edges are clipped to produce a square image. This should matter if the photo is taken portrait or landscape, and the thumbnails will line up nicely.

perkinss commented 12 years ago

I wonder if we should just get rid of the thumbnail code if we're just going to clip it anyhow? Or maybe the thumbnail can be created as a square… I guess whatever is easiest on this short deadline :) Susan Perkins suziep1@me.com

On 2012-09-28, at 3:44 PM, jrproctor notifications@github.com wrote:

I changed the thumbnail procedure to guarantee a square thumbnail is produced. edges are clipped to produce a square image. This should matter if the photo is taken portrait or landscape, and the thumbnails will line up nicely.

— Reply to this email directly or view it on GitHub.