perky / Minechem

Add chemistry to minecraft.
http://www.minecraftforum.net/topic/988773-11-minechem-v15/
23 stars 7 forks source link

The lead chest is broken (when placed next to a normal chest) #90

Closed imayhaveborkedit closed 11 years ago

imayhaveborkedit commented 11 years ago

It also breaks when punched.

leadchestnotwork

Rushmead commented 11 years ago

Could just describe what you do??

imayhaveborkedit commented 11 years ago

I placed the lead chest next to the normal one. It renders like this. That outline is where the lead chest actually is. It still works, but rendering is borked.

perky commented 11 years ago

It's because the chemical chest subclasses the normal chest. Need to override some method in BlockChemicalStorage to prevent this.

Regards, Ljdp

On 9 Jan 2013, at 11:34 PM, Daniel notifications@github.com wrote:

I placed the lead chest next to the normal one. It renders like this. That outline is where the lead chest actually is. It still works, but rendering is borked.

— Reply to this email directly or view it on GitHub.

Rushmead commented 11 years ago

ljdp! are you able to hop into irc i need to speak

perky commented 11 years ago

Sorry, can't come in irc

On 10 Jan 2013, at 06:49 PM, Rushmead notifications@github.com wrote:

ljdp! are you able to hop into irc i need to speak

— Reply to this email directly or view it on GitHub.

Rushmead commented 11 years ago

Ok theres some things... The localization is broken... We cant load it.. if you want it just english then we have to swap it to set it manually instead of use a file otherwise we need to rethink the whole thing!

perky commented 11 years ago

Is there a reason we can't load it? When I tested pr6 it worked fine...

On 10 Jan 2013, at 07:26 PM, Rushmead notifications@github.com wrote:

Ok theres some things... The localization is broken... We cant load it.. if you want it just english then we have to swap it to set it manually instead of use a file otherwise we need to rethink the whole thing!

— Reply to this email directly or view it on GitHub.

Rushmead commented 11 years ago

on 1.4.7?

perky commented 11 years ago

Not tested in 1.4.7, but there obviously is a way to load language files, I think the method name must have changed or something.

perky commented 11 years ago

Can you create a separate issue for this?

Rushmead commented 11 years ago

Well its all the same... Ill repull it and test again

Rushmead commented 11 years ago

after testing it is the file that is breaking doing this