search

perl-catalyst / FCGI

Fast CGI module (https://metacpan.org/pod/FCGI)
Other
4 stars 6 forks source link

Fix unix domain socket tests on Windows #10

Open michal-josef-spacek opened 1 year ago

michal-josef-spacek commented 1 year ago

There is no support in FCGI for this type of usage.

michal-josef-spacek commented 1 year ago

RT issue: https://rt.cpan.org/Ticket/Display.html?id=138257

michal-josef-spacek commented 1 year ago

Tested on Linux and Windows by me

michal-josef-spacek commented 1 year ago

@PhilterPaper My intent with FCGI is to add tests for functional things. After it, I want to fix the library (not working say, ipv6, deprecated functions). Unix sockets on Windows could be new functionality.

PhilterPaper commented 1 year ago

OK, I made your change to the t-test and upgraded my FCGI to 0.82. At least now it will stop bugging me to update it. I take it that so long as Windows doesn't support this kind of socket, you'll skip that OS, and if you do get a fix, you'll re-enable it. Do you also skip sockets on Windows in the FCGI code (not just the t-tests), or is that just "user beware"? Happy Holidays!

michal-josef-spacek commented 1 year ago

@PhilterPaper Yes, something like this.