Add test for FCGI over unix domain socket

perl-catalyst / FCGI

Fast CGI module (https://metacpan.org/pod/FCGI)

Other

4 stars 6 forks source link

Add test for FCGI over unix domain socket #6

Closed michal-josef-spacek closed 3 years ago

karenetheridge commented 3 years ago

Looks good, thanks! It's a bit embarassing that there were no tests :)

karenetheridge commented 3 years ago

I'm probably going to revert this. The tests aren't passing on MSWin32, and FCGI::Client uses Any::Moose, which is not something I think we should be reintroducing into people's dependency chains.

michal-josef-spacek commented 3 years ago

@karenetheridge In FCGI::Client 0.09 was switch to Moo (instead of Any::Moose). So I am proposing to add dependency to 0.09 version of FCGI::Client.

michal-josef-spacek commented 3 years ago

@karenetheridge I created issue for unix socket on Windows (https://rt.cpan.org/Ticket/Display.html?id=138057). I will prepare PR for it.

michal-josef-spacek commented 3 years ago

@karenetheridge https://github.com/perl-catalyst/FCGI/pull/7 and https://github.com/perl-catalyst/FCGI/pull/8