Do we need to override $SIG{INT} in this module?

perl-net-saml2 / perl-XML-Sig

XML::Sig - A Perl toolkit to help sign and verify XML Digital Signatures.

https://metacpan.org/pod/XML::Sig

1 stars 2 forks source link

Do we need to override $SIG{INT} in this module? #43

Closed dforkner closed 1 year ago

dforkner commented 1 year ago

This line in XML::Sig:

$SIG{INT} = sub { die "Interrupted\n"; };

overrides global signal handling when the module is loaded. In particular, this interferes with the ability to break a Perl program in the debugger with Ctrl+C without some workarounds. Does this need to be here?

timlegge commented 1 year ago

Its been here since the first commit. I can't really think of a a reason. https://github.com/perl-net-saml2/perl-XML-Sig/blob/fedc825c5af60794d39c19c253fe9b2bd509be76/lib/XML/Sig.pm#L31

Let me ask around but I suspect we can drop the line

TIm