search

perl-net-saml2 / perl-XML-Sig

XML::Sig - A Perl toolkit to help sign and verify XML Digital Signatures.
https://metacpan.org/pod/XML::Sig
1 stars 2 forks source link

Allow verification on one node: #55

Closed waterkip closed 1 year ago

waterkip commented 1 year ago

The following changeset implements the following equivalent of xmlsec1:

/usr/bin/xmlsec1 --verify --id-attr:ID \
    urn:oasis:names:tc:SAML:2.0:protocol:ArtifactResponse
timlegge commented 1 year ago

Unless you have a reason for 91

git rename t/091_verify-xml-with-id.t t/025_verify-xml-with-id.t

except line 710 $_->getValue // '' seems to break perl 5.8

I am fine with that just adjust the version required...

waterkip commented 1 year ago

except line 710 $_->getValue // '' seems to break perl 5.8

I am fine with that just adjust the version required...

Yeah, // syntax is perl 5.10 and up. I made a small change fixing that. Perhaps dropping perl 5.8 is a better option.

timlegge commented 1 year ago

lgtm - merge when ready - when do you need a release?