perl-pod / pod-simple

Framework for Parsing and Formatting POD
http://search.cpan.org/dist/Pod-Simple/
44 stars 60 forks source link

configure requires ExtUtils::MakeMaker 6.64 #129

Closed skaji closed 4 years ago

skaji commented 4 years ago

Currently we cannot install Pod::Simple with old perls because it requires ExtUtils::MakeMaker 6.64 in configure phase, but it is not listed in META.json.

❯ perl -v

This is perl 5, version 16, subversion 3 (v5.16.3) built for darwin-2level
...

❯ curl -fsSL https://cpanmin.us | perl - Pod::Simple
--> Working on Pod::Simple
Fetching http://www.cpan.org/authors/id/K/KH/KHW/Pod-Simple-3.41.tar.gz ... OK
Configuring Pod-Simple-3.41 ... N/A
! Configure failed for Pod-Simple-3.41. See /Users/skaji/.cpanm/work/1604583331.23818/build.log for details.

❯ tail -13 /Users/skaji/.cpanm/work/1604583331.23818/build.log
--> Working on Pod::Simple
Fetching http://www.cpan.org/authors/id/K/KH/KHW/Pod-Simple-3.41.tar.gz
-> OK
Unpacking Pod-Simple-3.41.tar.gz
Entering Pod-Simple-3.41
Checking configure dependencies from META.json
Checking if you have ExtUtils::MakeMaker 6.58 ... Yes (6.63_02)
Configuring Pod-Simple-3.41
Running Makefile.PL
ExtUtils::MakeMaker version 6.64 required--this is only version 6.6302 at Makefile.PL line 12.
BEGIN failed--compilation aborted at Makefile.PL line 12.
-> N/A
-> FAIL Configure failed for Pod-Simple-3.41. See /Users/skaji/.cpanm/work/1604583331.23818/build.log for details.

This PR adds ExtUtils::MakeMaker 6.64 to CONFIGURE_REQUIRES.

khwilliamson commented 4 years ago

Thanks for bringing this up. We discussed this, and people felt that requiring 6.64 on such a basic module was wrong; that we should instead get it to work on earlier versions. So someone worked up a different solution that we are going with that doesn't force such a high EUMM. #130. I believe your patch would work fine as-is; it's just that we think we shouldn't require 6.64

skaji commented 4 years ago

@khwilliamson Fair enough, thanks!

skaji commented 3 years ago

@khwilliamson Could you make a new release?