search

perladvent / Perl-Advent

The Perl Advent calendar
https://perladvent.org/
40 stars 62 forks source link

Remove duplicate css #405

Closed thibaultduponchelle closed 9 months ago

thibaultduponchelle commented 9 months ago

These files are just duplicates of css that are generated by WWW::AdventCalendar. They should only contain extra styles. I did not remove them because they are still included (404) even if not present at generation time.

oalders commented 9 months ago

There was a small change in #332. Is that getting removed here? I'm on my phone, so haven't checked.

thibaultduponchelle commented 9 months ago

It will be there in style.css (instead 2023.css) thanks to https://github.com/perladvent/WWW-AdventCalendar/pull/1

thibaultduponchelle commented 9 months ago

Oh wait, https://github.com/perladvent/WWW-AdventCalendar/pull/1 is not merged yet

thibaultduponchelle commented 9 months ago

Actually, we can configure for "extra" css or no "extra" css at all in advent.ini I updated this pull request to do this way.

But it's still not ready to merge until https://github.com/perladvent/WWW-AdventCalendar/pull/1 is sorted out to preserve @bbrtj improvement from #332

thibaultduponchelle commented 9 months ago

Now waiting for https://github.com/perladvent/WWW-AdventCalendar/pull/3 to be merged first