search

perladvent / Perl-Advent

The Perl Advent calendar
https://perladvent.org/
40 stars 62 forks source link

MooseX::Extended Article #422

Closed Ovid closed 1 month ago

Ovid commented 3 months ago

Here's my MooseX::Extended article. Let me know if there are any changes you'd like me to make.

I tried building locally with the README instructions, but it appears there are some bits which might be missing.

for year in $(seq 2011 2024); do cd $year && advcal -c advent.ini -o `pwd` && cd ..; done
...
cannot remove path when cwd is <snip>/perl-advent/2024 for <snip>/perl-advent/2024:  at <snip>/perl-5.40.0/lib/site_perl/5.40.0/Path/Class/Dir.pm line 155.

I had gotten that far because I previously tried ./script/build-site.sh --single-year 2024 which appeared to be successful.

Ovid commented 2 months ago

@openstrike Thank you for your suggestions. I've applied them!

Ovid commented 2 months ago

@openstrike Oops! Fixed, thank you 🙏

oalders commented 2 months ago

@openstrike is there anything else to address here?

openstrike commented 2 months ago

I think it is fine now, other than if someone wants to test that the code snippets work as expected.

Ovid commented 1 month ago

Er, I just noticed L<MooseX::Extende> in the article, when it should be L<MooseX::Extended>. I tried to check out perladvent:main to make a new PR, but in updating my local git repo, I can't find it. How do I fix this?

oalders commented 1 month ago

I've fixed the typo in #439. Thanks for pointing that out, @Ovid!