perladvent / perldotcom

The source code for Perl.com website
https://www.perl.com
77 stars 80 forks source link

/article/index.xml contains href links to perl.com #306

Closed raiph closed 3 years ago

raiph commented 3 years ago

Expected

Links from /article/index.xml (linked from several places on the perldotcom.perl.org home page, eg a button in the MORE: section at top right) that were to perl.com would now either warn or link to perldotcom.perl.org instead of perl.com.

Actual

The xml I got as of 1st Feb 2021 is in this GH gist.

If you search it you should see it contains 3 href links to www.perl.com/....

Comments

In https://www.reddit.com/r/perl/comments/l7bwn5/perldotcomperlorg_is_a_temporary_host_for_perlcom/gl85hun/ briandfoy says "To me, things look as they should be.".

Although I don't see why it would make a difference, I cleared my browser's file cache just in case. It didn't fix the problem.

System info

Windows 10 Version 2004 Installed on 04/11/2020 OS build 19041.746 Experience 120.2212.551.0

Google Chrome Version 87.0.4280.141 (Official Build) (64-bit)

briandfoy commented 3 years ago

I don't see any perl.com links your gist output. There is the site title "Perl.com", but those aren't links. We're considering what to do with the branding, but that's blocked by a few things at the moment.

raiph commented 3 years ago

Hi @briandfoy,

I don't see any perl.com links your gist output.

Did you click Raw and search for 'perl.com' or just look? Did you see, for example:

previously written about Stupid Open Tricks

?

That might not be a problem, but it's one of the 3 I said were hrefs, and if it's part of a title, well, it still looks to me like it'll be clickable.

briandfoy commented 3 years ago

I looked at the gist and didn't bother to look at the raw. This is why I've asked you before to be very specific. If I have to dig for buried treasure that you've already found, you aren't making the best report that you can make. For example, you could have said "In the article excerpt I found this link for this particular article" then linked to the raw source, since that's the link that gets me (or anyone) to the thing that demonstrates the problem.

briandfoy commented 3 years ago

The feed stuff has solved itself when we redeployed the site earlier today. The resource at https://perldotcom.perl.org/ now uses the new base URL.