search

perladvent / perldotcom

The source code for Perl.com website
https://www.perl.com
77 stars 80 forks source link

Why I wrote Net::Google::CivicInformation #318

Closed 1nickt closed 3 years ago

1nickt commented 3 years ago

Hi Brian and David. Here you go!

briandfoy commented 3 years ago

This is really, really good.

1nickt commented 3 years ago

Thanks Brian. I'll have another go at it this evening.

I must be lacking caffeine, or just dense: what is POC ?

Thanks

On Tue, Feb 9, 2021 at 11:45 PM brian d foy notifications@github.com wrote:

This is really, really good.

  • Screenshot of your website
  • Also link to your blogs.perl.org post
  • Maybe a paragraph about the OCD. Even reading about it now I'm like wtf?
  • Find some way to have one code block—maybe just show the UserAgent call.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tpf/perldotcom/pull/318#issuecomment-776436236, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBWYXK2WDDW4BR2Y7IWUWTS6IFPZANCNFSM4XMCE77A .

briandfoy commented 3 years ago

I think our autocorrect identifier got to us there. The OCD id is the Open Civic Data identifier.

1nickt commented 3 years ago

Gotcha

On Wed, Feb 10, 2021 at 4:48 PM brian d foy notifications@github.com wrote:

I think our autocorrect identifier got to us there. The OCD id is the Open Civic Data identifier.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tpf/perldotcom/pull/318#issuecomment-777050444, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBWYXJ2EJHHBTRJ2T47WNDS6L5LRANCNFSM4XMCE77A .

1nickt commented 3 years ago

Updated with OCD, code samples & self-edit. How should I deliver the screenshot?

briandfoy commented 3 years ago

This is looking good and I should be able to get to it this weekend. We also need a few other things:

1nickt commented 3 years ago

This is done, thanks Brian.

On Wed, Feb 17, 2021 at 12:11 AM brian d foy notifications@github.com wrote:

This is looking good and I should be able to get to it this weekend. We also need a few other things:

  • author json file in data/author. Follow the examples already there.
  • author pic in static/images/author (filename goes in the json file, but it typically the same name as the json file).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tpf/perldotcom/pull/318#issuecomment-780303368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBWYXJVVCN2ZBDDSAHLOUTS7NFZ3ANCNFSM4XMCE77A .

briandfoy commented 3 years ago

I should be able to work on this during the weekend. I think everything is very close.

briandfoy commented 3 years ago

I merged this in a local branch I had (8208d8ee3de8c8540fc8bf643503e80119e66e26). I made a few very minor adjustments and added a screen shot of the site. I'll publish this on March 8.

You can look at it in master and make new pull requests for anything you want to adjust.

Thanks!