perladvent / perldotcom

The source code for Perl.com website
https://www.perl.com
77 stars 80 forks source link

First set of files to be updated using the mcpan shortcode. #322

Closed wpr-curly2000 closed 3 years ago

wpr-curly2000 commented 3 years ago

Hi Brian,

As you proposed, I have updated 2 files with the mcpan shortcode:

legacy/_pub_2003_04_17_filters.md and legacy/_pub_2003_07_08_mod_perl.md

Since you cannot attach '.md' files directly. I have appended a '.txt' to each file. Pls let me know if there is an easier way to do attach these files.
_pub_2003_07_08_mod_perl.md.txt _pub_2003_04_17_filters.md.txt

Thanks, Jeff.

briandfoy commented 3 years ago

Thanks for doing more work. But, we need to adjust how you do this. There are 41 changed files in this PR and that's unwieldy to handle. Next time, choose one or two files at a time.

briandfoy commented 3 years ago

Okay, I think I see what happened.

Update to the latest master of this repo then make your changes for those two files. Submit a new pull request and we should just see those two files changed. When you do work again, update master first. Always update before you start work.

git checkout master
git pull
git checkout -b branch_name

After you push, delete your branches. You can use the same branch name again later, but you don't want something connected to a much earlier part of the history.

git branch -D branch_name
git push origin :branch_name

As such, I'm closing this PR so you can redo it.

wpr-curly2000 commented 3 years ago

Mea Culpa Brian!

Thanks for your patience and insight! I will get the repo updated and run the commands as you have as you have outlined.

Thanks, Jeff.