search

perladvent / perldotcom

The source code for Perl.com website
https://www.perl.com
77 stars 80 forks source link

What's New on CPAN for November 2023 #350

Closed matstar2 closed 6 months ago

matstar2 commented 6 months ago

New article plus some changes to DF's script for article scaffolding (probably should have excluded that?)

matstar2 commented 6 months ago

Hi Olaf, that bit I commented out gives interactive category override before rendering the article. I found that I prefer doing those edits in markdown.

Mat

On Dec 22, 2023 4:13 p.m., Olaf Alders @.> wrote: You don't often get email from @. Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

@oalders requested changes on this pull request.

\o/

It's great to see this back. I just had a couple of comments.

In bin/format-cpan-uploadshttps://github.com/perladvent/perldotcom/pull/350#discussion_r1435147686:

@@ -71,10 +71,11 @@ for my $release (sort @lines) sprintf('%s %s', $module{mcpan_link}, $module{description}), sprintf('%s can %s', $module{mcpan_link}, $module{description}), );

  • $module{description} = $descriptions[ int rand @descriptions ];

  • $module{description} = $descriptions[ int rand @descriptions ];

I think rather than commenting out code, we can delete it. It's easy enough to revert changes since they're tracked by git anyway.

In bin/format-cpan-uploadshttps://github.com/perladvent/perldotcom/pull/350#discussion_r1435149151:

  • {
  • next unless $answer =~ /^\d$/ && $answer < @categories;
  • $module{category} = $categories[$answer];
  • }

  • for (sort keys %categories)

  • {

  • my $current = $module{category} eq $_ ? '*' : ' ';

  • push @categories, $_;

  • printf " %s[%u] %s\n", $current, @categories - 1, $_;

  • }

  • my $answer = <<>>; chomp $answer;

  • if ($answer)

  • {

  • next unless $answer =~ /^\d$/ && $answer < @categories;

  • $module{category} = $categories[$answer];

  • }

Why is this commented out?

— Reply to this email directly, view it on GitHubhttps://github.com/perladvent/perldotcom/pull/350#pullrequestreview-1794616116, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHPZ2LREFU4QO5SRLBBSWK3YKWPSDAVCNFSM6AAAAABA663M4CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJUGYYTMMJRGY. You are receiving this because you authored the thread.Message ID: @.***>

oalders commented 6 months ago

@rwp0 do you have permissions to merge this pull request?

rwp0 commented 6 months ago

@rwp0 do you have permissions to merge this pull request?

Unfortunately, no.

image

oalders commented 6 months ago

@matstar2 I think it would be best to have the article in one commit and the changes to the script in a different commit. That would make it easier to roll back the changes to the script later if we needed to.

rwp0 commented 6 months ago

@matstar2 Could you please tell us why did you close this PR?

matstar2 commented 6 months ago

Hi, I am replacing it with another one. Coming in a moment...

Mat

On 2023-12-25 3:48 p.m., Elvin Aslanov wrote:

You don't often get email from @.*** Learn why this is important https://aka.ms/LearnAboutSenderIdentification

@matstar2 https://github.com/matstar2 Could you please tell us why did you close this PR?

— Reply to this email directly, view it on GitHub https://github.com/perladvent/perldotcom/pull/350#issuecomment-1869113446, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHPZ2LWREEMQQJBCVH2LEGLYLHRABAVCNFSM6AAAAABA663M4CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRZGEYTGNBUGY. You are receiving this because you were mentioned.Message ID: @.***>