Support Locationiq API - Githubissues

perliedman / leaflet-control-geocoder

A simple geocoder form to locate places. Easily extended to multiple data providers.

http://www.liedman.net/leaflet-control-geocoder/

BSD 2-Clause "Simplified" License

560 stars 220 forks source link

Support Locationiq API #268

Closed Daredzik closed 4 years ago

Daredzik commented 4 years ago

Locationiq API (its based od nominatim api but need to provide key and some endpoint have different url) https://locationiq.com/docs

Daredzik commented 4 years ago

@perliedman what do you think about it ??

Daredzik commented 4 years ago

@perliedman yes its a nice suggestion, but it's not that easy. Coz Locationiq endpoints are not equals to Nominatim, example: Nominatim version : reverse Locationiq version: reverse.php

How you want to change this using extend without modified Nominatim class ? Do you want me to change Nominatim class too ?

perliedman commented 4 years ago

Hm, yes I see. I think it could be reasonable to modify the Nominatim class so that the endpoint names are options, that you can then override in Locationiq. It's not entirely unlikely that this change could also be useful in other scenarios.

simon04 commented 4 years ago

Feel free to reopen once you address the requested changes.