search

perliedman / leaflet-control-geocoder

A simple geocoder form to locate places. Easily extended to multiple data providers.
http://www.liedman.net/leaflet-control-geocoder/
BSD 2-Clause "Simplified" License
560 stars 220 forks source link

Recent changes break draggable Leaflet markers #313

Closed ivoras closed 3 years ago

ivoras commented 3 years ago

Hi!

Thanks for creating leaflet-control-geocoder, it's been great to use!

Yesterday, though, I've noticed draggable markers in my app simply stopped working, with an infinite loop/recursion in events, which lead to stack overflows. That was surprising as it was working fine just a day ago. When digging in, I noticed one of the few packages I'm pulling in from unpkg without a version number was leaflet-control-geocoder, and that it was the culprit.

See this JS fiddle:

https://jsfiddle.net/ivoras/j5bfehLd/2/

If line 10 is commented out, dragging markers works fine. If it's active, you can observe the stack overflow in the js console.

Could you provide a VERSIONED link to the package's JS/CSS in the main example, so users don't get different code overnight?

grubshka commented 3 years ago

Hi, I just had the bug, found this issue, and saw version 2.0.1 release that fixed this. All this in a few minutes :-) Thanks !

simon04 commented 3 years ago

Duplicate of #312