perliedman / leaflet-routing-machine

Control for routing in Leaflet
https://www.liedman.net/leaflet-routing-machine/
Other
1.09k stars 352 forks source link

Improve itinerary description #9

Open perliedman opened 10 years ago

perliedman commented 10 years ago

The text description of a route is sometimes hard to follow, and not very detailed. Look into what can be improved.

See for example: https://github.com/perliedman/leaflet-routing-machine/issues/6#issuecomment-38325060

moimael commented 9 years ago

Any progress on this ? I get not only undetailed but sometimes empty instructions, which look awful in the UI (it result in a empty list item).

perliedman commented 9 years ago

@moimael wow! Do you have an example (waypoint coords or similar) where this happens?

moimael commented 9 years ago

capture d ecran de 2015-02-26 13 20 27

Just try to route from Paris to lille for example. It happens almost on every route I try.

TheMarex commented 9 years ago

@moimael the frontend is not really to blame here. The main problems are:

There is some code in OSRM to generate better turn instructions, but currently it is too slow to be used in production:

perliedman commented 9 years ago

@TheMarex good to know. Do you know a relevant issue for OSRM-backend we could l link to here? https://github.com/Project-OSRM/osrm-backend/issues/685 seems like it could be related.

moimael commented 9 years ago

@TheMarex Thanks for the explaination ! Do you have any pointer to speed up OSRM code ?

TheMarex commented 9 years ago

@moimael to be honest its not a really priority at the moment. If you would like to take a step yourself, we are always happy to help new contributors.